Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Crates, Npm Package and Usage Docs #21

Merged
merged 8 commits into from
May 24, 2022

Conversation

appcypher
Copy link
Member

@appcypher appcypher commented May 20, 2022

Summary

This PR implements the following features

  • Publish new crates.
  • Publish to npm.
  • Add usage examples

This PR just prepares the project for package publishing (npm, doc.rs, crates.io). Also adds usage examples.

WNFS NPM package:

WNFS crates:

Examples of WNFS usage here:
JavaScript:

Rust:

Test plan (required)

  • N/A

Ongoing Issues

Closing issues

Fixes #22

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022

Codecov Report

Merging #21 (f6a43d7) into main (8bb0fbb) will increase coverage by 0.13%.
The diff coverage is 84.04%.

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   79.91%   80.05%   +0.13%     
==========================================
  Files           9        9              
  Lines         712      732      +20     
==========================================
+ Hits          569      586      +17     
- Misses        143      146       +3     
Impacted Files Coverage Δ
crates/fs/public/file.rs 84.21% <ø> (ø)
crates/wasm/fs/public/directory.rs 0.00% <ø> (ø)
crates/fs/public/directory.rs 85.33% <81.01%> (-0.75%) ⬇️
crates/fs/public/link.rs 68.00% <100.00%> (+4.00%) ⬆️
crates/fs/public/node.rs 60.52% <100.00%> (+5.98%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@appcypher appcypher changed the title Publish Crates, Npm Packages and Docs Publish Crates, Npm Package and Usage Docs May 20, 2022
@appcypher appcypher force-pushed the appcypher/packages-doc-examples branch from 8cb532b to f466363 Compare May 23, 2022 15:48
@appcypher appcypher force-pushed the appcypher/packages-doc-examples branch from de5b22e to e60649d Compare May 23, 2022 17:46
@appcypher appcypher requested a review from matheus23 May 23, 2022 17:46
Copy link
Member

@matheus23 matheus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment about the wnfs scripts (and generally some ideas around where to go from there with our builds scripts).
I think we should at least rename it, but other than that this is good to go!

Docs 🙌 ✨

:shipit:

README.md Outdated
@@ -85,9 +180,9 @@ Its goal is to be as dependency-less as possible in order to be easily compiled

</details>

- **The _wnfs_ Helper Script**
- **The _wnfs_ Command**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should rename the script in order to avoid confusion with a potential wnfs CLI that actually reads and writes WNFS similar to what the ipfs CLI is doing today.

Or we could go for a Justfile which is similar to a makefile, but simpler. We're using it in a lot of other places at fission.

And lastly we could go for a nix version, but that's way more involved to set up compared to a justfile.

Copy link
Member Author

@appcypher appcypher May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was considering make but had issues with it in the past. Just looks like an improved make. I'm going to switch to it later.
I agree with renaming it. Maybe rs-wnfs because it is specific to the repo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about build-wnfs.sh? Or maybe make-wnfs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rs-wnfs fine too probably.

@appcypher appcypher merged commit 4170b8e into main May 24, 2022
@matheus23 matheus23 deleted the appcypher/packages-doc-examples branch December 2, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish WNFS Packages and Add Usage Documentation
3 participants